Help Me Humpa

Phree · Joined: 31 Dec 2005 Posts: 254 Location: South Coast, UK

Hey

I was trying to edit a file at work last night and was working on the server thru my CPanel. I always make a copy of the file rather than work on the original and I tried to do this, but somehow, I managed to delete the original file - and ended up with no copy of it Sad

So basically, somehow I've been a bit of a dick. I've found what I thought was the original file, but for some reason it doesn't work. I don't get any errors, but when I fill in the details and then hit "Create Account", it just reloads the script. When you've got a spare 5, could you please run your keen eye over it and perhaps let me know what I'm doing wrong?

create.php:

Humpa · Site Admin Joined: 06 Nov 2005 Posts: 10258

stick some echo lines in various places to see how far the code is getting ... that's what i do.

use echo "1. nick is $nick and email is $email and pwd1 is $pwd1 and pwd2 is $pwd2<br>";

And just paste that line in different places, starting with the isFaulty function (just put them on a line right before each "if" statement)

But use change the number, so you can tell which echo lines are showing, you know?
Just spread these out throughout your code:

echo "1. nick is $nick and email is $email and pwd1 is $pwd1 and pwd2 is $pwd2<br>";
echo "2. nick is $nick and email is $email and pwd1 is $pwd1 and pwd2 is $pwd2<br>";
echo "3. nick is $nick and email is $email and pwd1 is $pwd1 and pwd2 is $pwd2<br>";

Phree · Joined: 31 Dec 2005 Posts: 254 Location: South Coast, UK

Hiya,

ok..Tried that. Now when I go to the page, I get this at the top:

4. nick is and email is and pwd1 is and pwd2 is
6. nick is and email is and pwd1 is and pwd2 is

Echo 4 is the code that starts:

Humpa · Site Admin Joined: 06 Nov 2005 Posts: 10258

what?

I have no idea what you are saying.

Show me the file with the echo lines in it, and paste in what displays on your browser when you try to create a user.

Humpa · Site Admin Joined: 06 Nov 2005 Posts: 10258

but the fact that the nick and email are empty should be telling us something ... by the way, the nick and email will be empty - but after you submit the form, then they should not be empty.

Phree · Joined: 31 Dec 2005 Posts: 254 Location: South Coast, UK

Eek! Ok, here goes...This is what my file now looks like:

Phree · Joined: 31 Dec 2005 Posts: 254 Location: South Coast, UK

Am I being my usual thick self here? Should I have one file that contains the form that is filled out and then another file which contains the script that the form submits to? At the moment, the file is calling itself(?):

Humpa · Site Admin Joined: 06 Nov 2005 Posts: 10258

I don't know.

Where did you get this script anyway?

I think you better just go and get it from them again.

Phree · Joined: 31 Dec 2005 Posts: 254 Location: South Coast, UK

Just a little update that may be of some help to others in the future.

I have managed to sort out my createuser.php - but spent hours and hours fixing it - when I already thought it wasn't broken. I couldn't understand why it "used to work and now it doesn't". It started annoying me more and more because I found my old image uploader didn't work either. SO I set about finding out exactly what was going on.

I have just found out that the PHP directive register_globals went from ON to OFF in PHP 4.2.0. I moved servers a couple of months ago and am currently running on PHP 4.4.2 - I guess my old server had a version below 4.2. I have also found a fix:

In my image uploader folder, I edited my .htaccess file (if you don't have one, you can create it) and just added:

Humpa · Site Admin Joined: 06 Nov 2005 Posts: 10258

Damn.
See? The fact that nick and email were empty was telling us something!

We should've used $nick = $_POST['nick']; and $email = $_POST['email'];
Since register_globals was off, it wasn't automatically doing that for you. Sad

Or we could've just put this at the begining of the file:

Phree · Joined: 31 Dec 2005 Posts: 254 Location: South Coast, UK

Yep, you got it in one! I eventually figured that by going through my file and putting $nick = $_POST['nick'] for all the inputs in my form (obviously substituting "nick" for each input name - "email"; "First name" etc - I think there's 8 of them) it would work. I still didn't know why though until I searched around earlier.

I did read that you could just edit (or add) the .htaccess file in root and put the command I just posted, but I guess if they turned it off, they did it for a reason so it's better to just use it in specific directories as and when needed?

Thanks for that piece of code as well - I'll use that in future Razz